Refactor angular modules to use settingsFactory instead of settings #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f settings Also avoids some potential function name clashes
|
Thanks @agileware-fj , could you please fix the linters. |
mlutfy
reviewed
May 20, 2024
| [ | ||
| $caseCategoryId, | ||
| $caseCategoryName, | ||
| ] = CRM_Civicase_Helper_CaseUrl::getCategoryParamsFromUrl(); |
There was a problem hiding this comment.
@agileware-fj Putting this on one line fixed all the civilint errors for me (same error in another file, I'll comment there too).
mlutfy
reviewed
May 20, 2024
| [ | ||
| $caseCategoryId, | ||
| $caseCategoryName, | ||
| ] = CRM_Civicase_Helper_CaseUrl::getCategoryParamsFromUrl(); |
There was a problem hiding this comment.
Merge on one line to fix civilint errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #985
Also moves some fairly generically named functions related to the angular module definitions into a class which may prevent clashes