BTHA-194: Ensure membership rate total can be calculated for line item #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahrukh-compuco
changed the title
shahrukh-compuco
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Before this PR we had an issue where when a user ‘record’ a payment against a membership contribution with total computed from membersjhiprate extension, the amount due is shown as the amount attached to the original membership type ‘minimum fee’ (ie, pre calculation from the membership fee calculator).
The event we added here #508, requires that contactID be sent, but in the line item create hook, the contact ID was null.
In this PR we have retrieved the set the contact ID from the line item contribution.
Before
The amount due is shown as the amount attached to the original membership type ‘minimum fee.
After
The amount due is shown as the amount calculated by the membership fee calculator.
