Clear torch memory cache in tests #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been running out of memory when running the test suite locally. If I clear the torch cache before the two worst memory hogs (the tiling tests) this helps the situation a lot.
constantinpape
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Makes sense! These tests would need a lot of memory. This is not an issue on the CPU where memory management is easier, but will become a problem on small GPUs (and I assume on MPS as well). Your fix looks good. It currently fails here because util._get_device is not on dev yet, but will be once #176 is merged. I will then merge this one.
|
The relevant functionality is now on dev so I will merge. |
constantinpape
merged commit a99a849
into
computational-cell-analytics:dev
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running out of memory when running the test suite locally. If I clear the torch cache before the two worst memory hogs (the tiling tests) this helps the situation a lot.