-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EM Generalist Finetuning #241
Conversation
anwai98
commented
Oct 24, 2023
- The training scripts for lm generalist datasets (still need to test it and add necessary docstrings)
- TODO: need to make sure the data exists before checking RoIs (for getting data splits), else the script will crash
This is good to go. I tested the training for a few epochs, looks fine. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one typo and am a bit confused why the LM files are still in this PR.
finetuning/generalists/training/electron_microscopy/train_em_generalist.py
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,116 @@ | |||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused why these files are part of this PR, they should have been merged via #228 already!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I might know the reason. Probably because I created a branch from lm-generalist
branch, hence it also took those new files into consideration (which at that moment weren't a part of master)
@@ -0,0 +1,97 @@ | |||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused why these files are part of this PR, they should have been merged via #228 already!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
… (code coverage, .DS_Store, embeddings, etc.)
Add codecov and switch to micromamba in CI
Enable GUI tests in CLI and add a simple GUI test.