Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xxh128 version of hashes for model #284

Conversation

hmaarrfk
Copy link
Contributor

Closes: #283

Computes speed of all hashes in approximately 1.8 seconds vs 6.3.

See https://github.com/Cyan4973/xxHash for more info

Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hmaarrfk !
(Gonna merge as soon as tests pass.)

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (71181d4) 39.72% compared to head (212e948) 40.60%.
Report is 28 commits behind head on dev.

Files Patch % Lines
micro_sam/sample_data.py 6.66% 14 Missing ⚠️
micro_sam/util.py 84.44% 7 Missing ⚠️
micro_sam/sam_annotator/_widgets.py 57.14% 3 Missing ⚠️
micro_sam/precompute_state.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #284      +/-   ##
==========================================
+ Coverage   39.72%   40.60%   +0.88%     
==========================================
  Files          33       33              
  Lines        4179     4174       -5     
==========================================
+ Hits         1660     1695      +35     
+ Misses       2519     2479      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@constantinpape constantinpape merged commit 7ad19d3 into computational-cell-analytics:dev Nov 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants