Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Resizing Input Prompts #299

Merged
merged 10 commits into from
Jan 3, 2024
Merged

Fix Resizing Input Prompts #299

merged 10 commits into from
Jan 3, 2024

Conversation

anwai98
Copy link
Contributor

@anwai98 anwai98 commented Jan 2, 2024

No description provided.

constantinpape
constantinpape reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks correct. Only a few minor comments on the implementation.

micro_sam/training/sam_trainer.py Outdated Show resolved Hide resolved
micro_sam/training/sam_trainer.py Show resolved Hide resolved
micro_sam/training/util.py Outdated Show resolved Hide resolved
@anwai98 anwai98 requested a review from constantinpape January 3, 2024 01:30
@anwai98 anwai98 marked this pull request as ready for review January 3, 2024 01:30
@constantinpape constantinpape merged commit 56a94cd into dev Jan 3, 2024
3 checks passed
@constantinpape constantinpape mentioned this pull request Jan 3, 2024
Closed
@anwai98 anwai98 deleted the aa-debug branch January 3, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@constantinpape constantinpape constantinpape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anwai98 @constantinpape