Add menu option for automatic segmentation modes #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @constantinpape,
I have a proposal (we can choose to not go ahead with this as well). I think allowing the users to choose their automatic segmentation console of choice explicitly would be a nice addition (this could be done previously by switching on and off the
Prefer Segmentation Decodercheck menu, however I think it's simpler to allow it as a drop-down choice of modes.The only thing I am worried about is confusing users for the case where
automatic_segmentation_mode: "ais"for default models, which at the moment will still work (in the background for AMG).Let me know what your thoughts are!
PS. Either ways, this would close #792.