Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make output_timeout configurable #156

Closed
wants to merge 2 commits into from
Closed

make output_timeout configurable #156

wants to merge 2 commits into from

Conversation

renefritze
Copy link

I've followed the plugin option for cell-timeout with this and used the previously hardcoded value of 5 as the new default. This would close #136.

@vidartf
Copy link
Collaborator

vidartf commented Dec 8, 2020

For clarity, do you have some examples of when this could be useful? Are you e.g. generating outputs asynchronously?

@renefritze
Copy link
Author

We've since moved on from using nbval, but I think the issue that was fixed for me with this commit was with pythreejs visualizations that wouldn't show otherwise. So my guess is yes, that was async related, but I'm not sure and can no longer check.

@Borda
Copy link

Borda commented Jun 17, 2021

We've since moved on from using nbval

so what are you using now?

I think the issue that was fixed

I see this argument in pytest help, but setting any walue does not have any effect #151 (comment)

@Borda
Copy link

Borda commented Jun 17, 2021

@fangohr @logicabrity @mvousden mind check this PR?

For clarity, do you have some examples of when this could be useful? Are you e.g. generating outputs asynchronously?

@vidartf on the other hand why have an existing argument that does not have any effect? 🐰

turned out that my cell is hanging even with a long timeout, so the issue is probably also elsewhere...

@mvousden
Copy link
Member

[...] @mvousden mind check this PR?

I don't think I'm an appropriate developer to review this, as I haven't contributed to this repository, and I don't have understanding of the issue you're trying to fix. @fangohr may be able to recommend someone suitable though!

@renefritze
Copy link
Author

We've since moved on from using nbval

so what are you using now?

We don't ship notebooks that need to be hooked into pytest anymore. We've switched to markdown tutorials in sphinx with myst-nb.

@renefritze
Copy link
Author

I'm cleaning up stale PRs, so I'll just leave this here in case there's interest in the future. patch.txt

@renefritze renefritze closed this Dec 21, 2021
@renefritze renefritze deleted the cell_output_timeout branch December 21, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output_timeout should be configurable
4 participants