Update webapp for private storage bucket #305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the webapp to work with a private storage bucket. Prior to this PR, the storage bucket was public and anyone could read files directly from it. Granted, the name of each zip file and picture were UUID's and thus, semi-private. However, this makes all files completely private, and access to them is controlled through the C/S authentication system.
The only substantial change required to make this happen was to route the screenshots through a new url
/storage/screenshots/[data_id].png
. Thanks to the Postgresql JSON field, this was easy to do. It turns out that you can query deeply nested JSON fields such as the "id" field in this data:This query will then find a
Simulation
object with an output that has the queried ID.Not going directly through to the Google Storage link for loading the screenshots seems to have a minor performance impact (100-200ms per screenshot load), but the privacy trade-off makes this tolerable.