Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of Clang/LLVM toolset of Visual Studio #648

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wizardsd
Copy link

Made it possible to use clang-cl.exe as a compiler on Windows in Visual Studio 2022.

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @wizardsd

PRs with changes for Conan 1.X should go to develop branch, not master.

I think the elseif(NOT MSVC_VERSION VERSION_LESS 1930 AND MSVC_VERSION VERSION_LESS 1950) was already merge to develop

Also, please take not that the Conan 1.X integration is no longer recommended. If there are risks of breaking, changes might not be merged. It doesn't seem high risk in this specific case, but we need to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants