Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conan.cmake to support actual version of Visual Studio 2022 #667

Open
wants to merge 1 commit into
base: release/0.18
Choose a base branch
from

Conversation

giovaorama
Copy link

As reported in https://cmake.org/cmake/help/latest/variable/MSVC_VERSION.html the maximum value for the visual studio 2022 is now less than 1950 not 1940. 1940 is the release 17.10

As reported in https://cmake.org/cmake/help/latest/variable/MSVC_VERSION.html
the maximum value for the visual studio 2022 is now less than 1950 not 1940. 1940 is the release 17.10
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@memsharded memsharded self-assigned this Aug 22, 2024
@memsharded
Copy link
Member

Hi @giovaorama

Thanks for your contribution. This has already been fixed and merged to develop branch in #643, marking this as a duplicate.

A release hasn't been done, because cmake-conan for 1.X is now legacy, the default and maintained one is Conan 2 using the new CMake dependency providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants