Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support list in conan command during version check #668

Open
wants to merge 1 commit into
base: develop2
Choose a base branch
from
Open

support list in conan command during version check #668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conan_provider.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ macro(conan_provide_dependency method package_name)
get_property(_conan_install_success GLOBAL PROPERTY CONAN_INSTALL_SUCCESS)
if(NOT _conan_install_success)
find_program(CONAN_COMMAND "conan" REQUIRED)
conan_get_version(${CONAN_COMMAND} CONAN_CURRENT_VERSION)
conan_get_version("${CONAN_COMMAND}" CONAN_CURRENT_VERSION)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not very clear. The CONAN_COMMAND variable is the one defined in the above find_program(), not a custom defined one, but you said you defined it as set(CONAN_COMMAND "py;conan_command.py"). Where did you defined it? And how it gets to this location with that value?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your script defines this variable at this point, but you don't own it—we can define it too! :)

At the beginning of CMakeLists.txt, we set up various configurations, including the CONAN_COMMAND. Because of this setup, CONAN_COMMAND is not being set by the find_program() call mentioned above (as described in the documentation: 'If the program is found, the result is stored in the variable, and the search will not be repeated unless the variable is cleared.').

As a result, we define CONAN_COMMAND before any actual work is done, meaning that when find_program() is invoked later, it effectively does nothing.

The conan_provider is used as advised with -DCMAKE_PROJECT_TOP_LEVEL_INCLUDES=../conan_provider.cmake. When CMake retrieves dependencies from Conan, conan_provide_dependency is called. By this point, our pre-setup has already executed, and CONAN_COMMAND has been set.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that approach is a bit risky, isn't it? If there is some other Conan installed in the system, the find_program() will find it and use it, while your intention was to use your own wrapper always, is that correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no sorry, you are right, if the find_program() finds that it is set, it will not even try to find it, reusing, it.
Understood, thanks for the clarification!

conan_version_check(MINIMUM ${CONAN_MINIMUM_VERSION} CURRENT ${CONAN_CURRENT_VERSION})
message(STATUS "CMake-Conan: first find_package() found. Installing dependencies with Conan")
if("default" IN_LIST CONAN_HOST_PROFILE OR "default" IN_LIST CONAN_BUILD_PROFILE)
Expand Down