adding spdlog/1.7.0 + add header only component + fixing hooks #2174

prince-chrismc · 2020-07-09T19:56:49Z

Specify library name and version: spdlog/1.7.0

fixes #2228

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2020-07-09T21:06:53Z

Some configurations of 'spdlog/1.4.2' failed in build 1 (3ccf311c2b2731589c380ac56c9d6318ca3c1090):

Linux x86_64, Release, gcc 8, libstdc++ . Options: spdlog:header_only-True
Access to all the logs

recipes/spdlog/all/conanfile.py

conan-center-bot · 2020-07-09T22:17:20Z

An unexpected error happened and has been reported. Help is on its way! 🏇

ytimenkov · 2020-07-10T09:08:48Z

Ooc: what is the reason for having a header-only component and how it can be used?
Do cmakefiles exported by spdlog natively have same set of components?

prince-chrismc · 2020-07-10T12:31:01Z

@ytimenkov

Ooc: what is the reason for having a header-only component and how it can be used?

It's a design choice of the maintainer, it shows there are two different and distinct modes of working with a library

Do cmakefiles exported by spdlog natively have same set of components?

💯 That's what we are trying to recreate, so whether you use Conan or not it should be a seamless integration

ytimenkov · 2020-07-10T12:47:42Z

Do cmakefiles exported by spdlog natively have same set of components?

💯 That's what we are trying to recreate, so whether you use Conan or not it should be a seamless integration

I see 👍. Can't tell now but have strange feeling about having deferent components (doing almost the same) depending on option.

conan-center-bot · 2020-07-10T12:57:22Z

Some configurations of 'spdlog/1.4.2' failed in build 3 (8641f35307bbc3307b765b91bc414a104d779b19):

Linux x86_64, Release, gcc 5, libstdc++ . Options: spdlog:shared-True
Access to all the logs

prince-chrismc · 2020-07-10T18:24:20Z

I see . Can't tell now but have strange feeling about having diferent components (doing almost the same) depending on option.

Personally I agree, however that it was what the project maintainer has decide to do. It's our responsibility its seamless offer via conan. there are other conan generators to simplify your work flow at the cost of being conan specific.

conan-center-bot · 2020-07-10T18:49:30Z

Some configurations of 'spdlog/1.4.2' failed in build 4 (ce1342507e94d1e11e2e7b8d2bd9a4096290c393):

Linux x86_64, Release, gcc 5, libstdc++ . Options: spdlog:shared-True
Access to all the logs

conan-center-bot · 2020-07-11T14:38:44Z

Some configurations of 'spdlog/1.7.0' failed in build 5 (758972d0a04630b8867bbc1e5cfd3b97d9e127a2):

Linux x86_64, Release, gcc 8, libstdc++ . Options: spdlog:header_only-True
Access to all the logs

conan-center-bot · 2020-07-11T21:36:52Z

An unexpected error happened and has been reported. Help is on its way! 🏇

only use one cpp_info global versus components refactor package_info missed a cpp_info global adding component requirements

…pilation when header_only=True

conan-center-bot · 2020-07-20T13:26:08Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2020-07-20T14:47:07Z

All green in build 8 (793cc487ff9a54eebbf6f4f66640f91013a18be2)! 😊

spdlog/1.4.2: Generated 125 packages. All logs here
spdlog/1.5.0: Generated 125 packages. All logs here
spdlog/1.6.0: Generated 131 packages. All logs here
spdlog/1.6.1: Generated 131 packages. All logs here
spdlog/1.7.0: Generated 131 packages. All logs here

recipes/spdlog/all/conanfile.py

Co-authored-by: Uilian Ries <[email protected]>

prince-chrismc · 2020-07-20T18:13:15Z

Should we add the fix for #2228 from 2233 ?

A: #2233 (comment)

Co-authored-by: Uilian Ries <[email protected]>

conan-center-bot · 2020-07-20T18:39:25Z

config.yml syntax error in build 10:

Only one library can be changed in the same PR: [entt/3.x.x, spdlog/all]|

prince-chrismc · 2020-07-20T18:41:48Z

the Bot is having problems with this PR 🤕

conan-center-bot · 2020-07-20T20:19:12Z

All green in build 11 (499147399979c83e45d29c9efb1b5bec5a6166ad)! 😊

spdlog/1.4.2: Generated 125 packages. All logs here
spdlog/1.5.0: Generated 125 packages. All logs here
spdlog/1.6.0: Generated 131 packages. All logs here
spdlog/1.6.1: Generated 131 packages. All logs here
spdlog/1.7.0: Generated 131 packages. All logs here

uilianries

LGTM

ytimenkov · 2020-07-21T11:55:29Z

recipes/spdlog/all/conanfile.py

+            self.cpp_info.components["libspdlog"].defines.append("SPDLOG_COMPILED_LIB")
+
+        self.cpp_info.components[component_name].defines.append("SPDLOG_FMT_EXTERNAL")
+        if self.options["fmt"].header_only:


Shouldn't this be other way around? I get

Component 'fmt::fmt-header-only' not found in 'fmt' package requirement ERROR: Component 'fmt::fmt-header-only' not found in 'fmt' package requirement

Your fmt package should be outdated. You can run conan install -U , or remove remove from cache and install again.

This didn't go away even after bumping fmt from 6.2.1 to the latest (7.somthing, this triggered pulling a new recipe).
I think it's being addressed in #2243

conan-center-bot added the Failed label Jul 9, 2020

prince-chrismc commented Jul 9, 2020

View reviewed changes

recipes/spdlog/all/conanfile.py Outdated Show resolved Hide resolved

conan-center-bot added the Unexpected Error label Jul 9, 2020

ytimenkov mentioned this pull request Jul 10, 2020

Update SPDLog to 1.7.0 gerbera/gerbera#943

Merged

prince-chrismc mentioned this pull request Jul 11, 2020

Spdlog 1.7.0 updates #2189

Closed

3 tasks

uilianries closed this Jul 13, 2020

uilianries reopened this Jul 13, 2020

prince-chrismc added 3 commits July 20, 2020 08:20

adding spdlog/1.7.0 + add header only component + fixing hooks

684a283

refactor package_info

a577170

only use one cpp_info global versus components refactor package_info missed a cpp_info global adding component requirements

🧪 remove patches since we have the components to find fmt + avoid com…

793cc48

…pilation when header_only=True

prince-chrismc force-pushed the update/spdlog branch from bd14116 to 793cc48 Compare July 20, 2020 12:22

prince-chrismc mentioned this pull request Jul 20, 2020

Bump spdlog 1.7.0 #2233

Closed

4 tasks

danimtb previously approved these changes Jul 20, 2020

View reviewed changes

conan-center-bot removed Unexpected Error Failed labels Jul 20, 2020

danimtb requested review from SSE4 and uilianries July 20, 2020 15:16

uilianries requested changes Jul 20, 2020

View reviewed changes

recipes/spdlog/all/conanfile.py Outdated Show resolved Hide resolved

Update recipes/spdlog/all/conanfile.py

bfcfd0a

Co-authored-by: Uilian Ries <[email protected]>

prince-chrismc dismissed danimtb’s stale review via bfcfd0a July 20, 2020 18:11

raise Invalidconfiguration when fmt API is not acceptable

4991473

Co-authored-by: Uilian Ries <[email protected]>

conan-center-bot added the Failed label Jul 20, 2020

conan-center-bot removed the Failed label Jul 20, 2020

uilianries approved these changes Jul 20, 2020

View reviewed changes

uilianries requested a review from danimtb July 20, 2020 20:27

SSE4 approved these changes Jul 21, 2020

View reviewed changes

danimtb approved these changes Jul 21, 2020

View reviewed changes

danimtb merged commit b1d8a1d into conan-io:master Jul 21, 2020

ytimenkov reviewed Jul 21, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding spdlog/1.7.0 + add header only component + fixing hooks #2174

adding spdlog/1.7.0 + add header only component + fixing hooks #2174

prince-chrismc commented Jul 9, 2020 •

edited

Loading

conan-center-bot commented Jul 9, 2020

conan-center-bot commented Jul 9, 2020

ytimenkov commented Jul 10, 2020

prince-chrismc commented Jul 10, 2020

ytimenkov commented Jul 10, 2020

conan-center-bot commented Jul 10, 2020

prince-chrismc commented Jul 10, 2020

conan-center-bot commented Jul 10, 2020

conan-center-bot commented Jul 11, 2020

conan-center-bot commented Jul 11, 2020

conan-center-bot commented Jul 20, 2020

conan-center-bot commented Jul 20, 2020

prince-chrismc commented Jul 20, 2020 •

edited

Loading

conan-center-bot commented Jul 20, 2020

prince-chrismc commented Jul 20, 2020

conan-center-bot commented Jul 20, 2020

uilianries left a comment

ytimenkov Jul 21, 2020

uilianries Jul 21, 2020

ytimenkov Jul 21, 2020 •

edited

Loading

adding spdlog/1.7.0 + add header only component + fixing hooks #2174

adding spdlog/1.7.0 + add header only component + fixing hooks #2174

Conversation

prince-chrismc commented Jul 9, 2020 • edited Loading

conan-center-bot commented Jul 9, 2020

conan-center-bot commented Jul 9, 2020

ytimenkov commented Jul 10, 2020

prince-chrismc commented Jul 10, 2020

ytimenkov commented Jul 10, 2020

conan-center-bot commented Jul 10, 2020

prince-chrismc commented Jul 10, 2020

conan-center-bot commented Jul 10, 2020

conan-center-bot commented Jul 11, 2020

conan-center-bot commented Jul 11, 2020

conan-center-bot commented Jul 20, 2020

conan-center-bot commented Jul 20, 2020

prince-chrismc commented Jul 20, 2020 • edited Loading

conan-center-bot commented Jul 20, 2020

prince-chrismc commented Jul 20, 2020

conan-center-bot commented Jul 20, 2020

uilianries left a comment

Choose a reason for hiding this comment

ytimenkov Jul 21, 2020

Choose a reason for hiding this comment

uilianries Jul 21, 2020

Choose a reason for hiding this comment

ytimenkov Jul 21, 2020 • edited Loading

Choose a reason for hiding this comment

prince-chrismc commented Jul 9, 2020 •

edited

Loading

prince-chrismc commented Jul 20, 2020 •

edited

Loading

ytimenkov Jul 21, 2020 •

edited

Loading