libcoro: add version 0.11.1

[toge]

Specify library name and version: libcoro/0.11

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[uilianries]

@toge That error is really weird, I'll investigate further. I now more options changed in 0.11 and probably some source is missing when building.

[uilianries]

Some weird behavior, when using cmake_dependent_option CMake feature with Conan, for some reason, it does not work.

https://c3i.jfrog.io/c3i/misc/logs/pr/22764/2-linux-gcc11/libcoro/0.11//1e83dbe0105b2ee2583fa6fe1489fdb74a950fe7-build.txt

Some options should enabled, they are not:

libcoro LIBCORO_EXTERNAL_DEPENDENCIES = ON
libcoro LIBCORO_BUILD_TESTS           = OFF
libcoro LIBCORO_CODE_COVERAGE         = OFF
libcoro LIBCORO_BUILD_EXAMPLES        = OFF
libcoro LIBCORO_FEATURE_NETWORKING    = ON
libcoro LIBCORO_FEATURE_TLS           = ON
libcoro LIBCORO_RUN_GITCONFIG         = OFF
libcoro LIBCORO_BUILD_SHARED_LIBS     = ON

Locally, running the same command like, but using only cmake in the docker image, with conanfile.txt, it works.

[uilianries]

@toge I did some changes to support the version 0.11.1. The new patch version fixes the current error. You can find a related discussion here:

• [hotfix] cmake_dependent_option requires CMake 3.25 jbaldwin/libcoro#251
• Revert cmake PROJECT_IS_TOP_LEVEL jbaldwin/libcoro#252

[uilianries]

I'll check the sys header missing.

[uilianries]

After checking the upstream's code, some options are not available on Windows, but the recipe did not have the logic, because until now we have supported only Linux gcc. I removed dynamically the affected options.

[uilianries]

The current error is because shared library was not supported before 0.11 and the custom patch available in CCI is bugged (need extra work due static variables). I'll remove those patches and keep it as static library. Since 0.11 anyone can use shared library with safety (tested in the upstream).

[toge]

@uilianries
Sorry conflicted!
I am goting to revert it.

[uilianries]

@toge No, I'm sorry of abusing your PR 😅 The fact is WINDOWS_EXPORT_ALL_SYMBOLS will not work here. CMake is capable to export all methods, but not static variables. The libcoro has 2 public static variables that need the dlspec directly in the code. You can see the real fix here: jbaldwin/libcoro#236

[toge]

@uilianries
Thank you for your information!
Now I understand.

[uilianries]

The CI is not smart enough to understand dynamic shared option. We will need to keep it, but manage as invalid configuration.

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 14 (35d0c5101f3be43a41c2ae84f8e13027d033ce3e):

• libcoro/0.10:
  All packages built successfully! (All logs)

• libcoro/0.9:
  All packages built successfully! (All logs)

• libcoro/0.11.1:
  All packages built successfully! (All logs)

• libcoro/0.8:
  All packages built successfully! (All logs)

• libcoro/0.7:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 13 (35d0c5101f3be43a41c2ae84f8e13027d033ce3e):

• libcoro/0.11.1:
  All packages built successfully! (All logs)

• libcoro/0.9:
  All packages built successfully! (All logs)

• libcoro/0.10:
  All packages built successfully! (All logs)

• libcoro/0.8:
  All packages built successfully! (All logs)

• libcoro/0.7:
  All packages built successfully! (All logs)

[uilianries]

@toge It's finally working! 🎉

[uilianries]

LGTM

[toge]

@uilianries
Thanks a lot!