-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add andreasbuhr-cppcoro/cci.20210113 #4629
Add andreasbuhr-cppcoro/cci.20210113 #4629
Conversation
This comment has been minimized.
This comment has been minimized.
Well I should've read the documentation more... It's |
This comment has been minimized.
This comment has been minimized.
This interesting, I thought MSVC doesn't need the /await flag for coroutines anymore if /std:c++latest? And it's the case locally too. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Windows and MacOS done. Linux's situation is a bit awkward because all the combination you can get with gcc/clang and libstdc++/libc++
|
According Compiler support page, Coroutines is only available since Clang 8.0. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I have zero clue why does clang 11 with libc++ doesn't build on CI (seems like coroutine library stuff are not there?). It works completely fine locally. Details
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes 😺
Co-authored-by: Javier G. Sogo <[email protected]>
This comment has been minimized.
This comment has been minimized.
if self.settings.compiler == "clang" and self.settings.compiler.get_safe("libcxx") == "libstdc++": | ||
raise ConanInvalidConfiguration("{} does not support clang with libstdc++. Use libc++ instead.".format(self.name)) | ||
|
||
# TODO remove once figured out why clang 11/libc++ doesn't build on CCI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like conan-io/conan-docker-tools#251
Co-authored-by: Chris Mc <[email protected]>
This comment has been minimized.
This comment has been minimized.
All green in build 18 (
|
hey, this recipe doesn't propagate the produced library in |
I've opened #6197. @hnOsmium0001, it would be nice if you could provide an example testing symbols in the lib. I'm too lazy to dig into this lib. |
Specify library name and version: andreasbuhr-cppcoro/cci.20210113
Closes #3293
This PR packages https://github.com/andreasbuhr/cppcoro instead of https://github.com/lewissbaker/cppcoro because the latter (original version) seems unmaintained and lacks a CMake buildscript. See lewissbaker/cppcoro#170
conan-center hook activated.