Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitelist libgphoto2 in kb-h050 hook #365

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

sparik
Copy link
Contributor

@sparik sparik commented Oct 14, 2021

@danimtb danimtb requested a review from SSE4 October 18, 2021 13:29
@ericLemanissier
Copy link
Contributor

This CI error is caused by an outdated tox environment. Does someone have the possibility to remove all these outdated environments ?

@madebr
Copy link
Contributor

madebr commented Oct 21, 2021

This CI error is caused by an outdated tox environment. Does someone have the possibility to remove all these outdated environments ?

@uilianries fixed CI in his pr at #280
Perhaps he/we need to extract the fix to its own pr, and commit that?

@ericLemanissier
Copy link
Contributor

ericLemanissier commented Oct 21, 2021

I don't know what you are talking about. What I see in the current CI log is ERROR: Install yamllint to use 'yaml_linter' hook: 'pip install yamllint' which is wrong because yamllint should have been installed as part of https://github.com/conan-io/hooks/blob/master/tests/requirements_test.txt#L8
It was not installed, because tox reused an existing environment. CF #358 (comment)

The gist is that we are bitten by tox-dev/tox#149 which will be solved in tox 4

@uilianries
Copy link
Member

@ericLemanissier @madebr Thank you for alerting! I've opened #366 I'll try a fresh install for every new CI build.

@sparik sparik closed this Oct 22, 2021
@sparik sparik reopened this Oct 22, 2021
@sparik
Copy link
Contributor Author

sparik commented Oct 22, 2021

I guess this can be merged now, right? @uilianries

@uilianries uilianries merged commit acd2029 into conan-io:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants