Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: MixThemeData can alter default order of modifiers #380

Merged
merged 5 commits into from
Jul 18, 2024
Merged

feat: MixThemeData can alter default order of modifiers #380

merged 5 commits into from
Jul 18, 2024

Conversation

tilucasoli
Copy link
Collaborator

@tilucasoli tilucasoli commented Jul 15, 2024 •
edited
Loading

Description

  • The ability to change the order of Modifiers applied to the Widget.

Changes

  • Create a directory modifiers/internal
  • Put RenderModifiers as an internal API
  • Add the parameter defaultOrderOfModifiers to MixThemeData

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 6:00pm

@github-actions github-actions bot added the mix label Jul 15, 2024
@tilucasoli tilucasoli changed the title create a way to modify modifier order feat: MixTheme can alter default modifiers order Jul 15, 2024
@tilucasoli tilucasoli changed the title feat: MixTheme can alter default modifiers order feat: MixTheme can alter default order of modifiers Jul 15, 2024
@tilucasoli tilucasoli marked this pull request as ready for review July 17, 2024 15:50
@tilucasoli tilucasoli requested a review from leoafarias July 17, 2024 15:50
@tilucasoli tilucasoli changed the title feat: MixTheme can alter default order of modifiers feat: MixThemeData can alter default order of modifiers Jul 17, 2024
leoafarias
leoafarias approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias leoafarias merged commit bbae869 into main Jul 18, 2024
6 checks passed
@leoafarias leoafarias deleted the feat/modify-default-modifier-order branch July 18, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoafarias leoafarias leoafarias approved these changes

Assignees
No one assigned
Labels
mix_generator mix_lint mix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilucasoli @leoafarias