fix: return empty pwd hash and salt if not exists

conceptadev · Feb 21, 2024 · b282535 · b282535
1 parent ae9464c
commit b282535
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/packages/nestjs-user/src/services/user-password.service.ts b/packages/nestjs-user/src/services/user-password.service.ts
@@ -90,18 +90,12 @@ export class UserPasswordService implements UserPasswordServiceInterface {
       // break out the stored password
       const { passwordHash, passwordSalt } = user;
 
-      // type guards
-      if (
-        typeof passwordHash === 'string' &&
-        typeof passwordSalt === 'string'
-      ) {
-        // return the user with asserted storage types
-        return { ...user, passwordHash, passwordSalt };
-      } else {
-        throw new UserException(
-          'User object is missing some or all password storage properties',
-        );
-      }
+      // return the user with asserted storage types
+      return {
+        ...user,
+        passwordHash: typeof passwordHash === 'string' ? passwordHash : '',
+        passwordSalt: typeof passwordSalt === 'string' ? passwordSalt : '',
+      };
     }
 
     // throw an exception by default