Feature/cache module #156
Merged
Feature/cache module #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMaz
reviewed
May 20, 2024
| import { format } from 'util'; | ||
| import { ExceptionInterface } from '@concepta/ts-core'; | ||
|
|
||
| export class AssignmentNotFoundException |
There was a problem hiding this comment.
Class name should be prefixed with Cache
| export const cacheDefaultConfig = registerAs( | ||
| CACHE_MODULE_DEFAULT_SETTINGS_TOKEN, | ||
| (): Partial<CacheSettingsInterface> => ({ | ||
| expiresIn: process.env.CACHE_EXPIRE_IN ? process.env.CACHE_EXPIRE_IN : '1d', |
There was a problem hiding this comment.
I think we should support no expiration date and default is to not expire (undefined)
Comment on lines
197
to
203
| private getExpirationDate(expiresIn: string) { | ||
| const now = new Date(); | ||
|
|
||
| // add time in seconds to now as string format | ||
| return new Date(now.getTime() + ms(expiresIn)); | ||
| } | ||
| } |
There was a problem hiding this comment.
duplicate method in cache service, should be utility?
Comment on lines
311
to
316
| private getExpirationDate(expiresIn: string) { | ||
| const now = new Date(); | ||
|
|
||
| // add time in seconds to now as string format | ||
| return new Date(now.getTime() + ms(expiresIn)); | ||
| } |
There was a problem hiding this comment.
duplicate method in cache controller, should be utility?
| */ | ||
| @Exclude() | ||
| export class CacheUpdateDto | ||
| extends PickType(CacheDto, ['key', 'type', 'assignee', 'data'] as const) |
There was a problem hiding this comment.
We should discuss if expiresIn should be allowed again if they want to reset the expiration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new cache module