update attribute visibility synchronously

concord-consortium · Aug 12, 2024 · 2a64a34 · 2a64a34
1 parent 5f7e545
commit 2a64a34
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/src/components/location-tab.tsx b/src/components/location-tab.tsx
@@ -42,17 +42,16 @@ export const LocationTab: React.FC<LocationTabProps> = ({
     getUniqueLocationsInCodapData
   } = useCodapData();
 
-  // TODO - this is causing re-render issues in v2, need to address attr visibility in a different way
-  // useEffect(() => {
-  //   const updateAttributesVisibility = async () => {
-  //     for (const attr of kChildCollectionAttributes) {
-  //       const isSelected = selectedAttrs.includes(attr.name);
-  //       await updateAttributeVisibility(attr.name, !isSelected);
-  //     }
-  //   };
+  useEffect(() => {
+    const updateEachAttrVisibility = () => {
+      for (const attr of kChildCollectionAttributes) {
+        const isSelected = selectedAttrs.includes(attr.name);
+        updateAttributeVisibility(attr.name, !isSelected);
+      }
+    };
 
-  //   updateAttributesVisibility();
-  // }, [selectedAttrs, updateAttributeVisibility]);
+    updateEachAttrVisibility();
+  }, [selectedAttrs, updateAttributeVisibility]);
 
   const handleLatChange = (event: React.ChangeEvent<HTMLInputElement>) => {
     setLatitude(event.target.value);

diff --git a/src/hooks/useCodapData.ts b/src/hooks/useCodapData.ts
@@ -86,11 +86,11 @@ export const useCodapData = () => {
     }
   };
 
-  const updateAttributeVisibility = async (attributeName: string, hidden: boolean) => {
+  const updateAttributeVisibility = (attributeName: string, hidden: boolean) => {
     if (!dataContext) return;
 
     try {
-      await updateAttribute(
+      updateAttribute(
         kDataContextName,
         kChildCollectionName,
         attributeName,