187887881 selected row sync #24
Conversation
- very hacky and not performant at the moment - needs revision - might need to adopt a "get notification -> ask codap" pattern - which means removing "get notification -> get data from notification" pattern
- use the ref values in handleCaseSelectionInCodap, rather than passing in the state vars, allowing us to use the ref values in handleCaseSelectionInCodap,allowing us to remove latitude, longitude, and dayOfYear from handleDataContextChange dependencies
| return null; | ||
| } | ||
| }).then((selectionResult: any) => { | ||
| if (!selectionResult.success) { |
There was a problem hiding this comment.
Wouldn't that line fail with null passed as selectionResult when the block above returns null?
| debouncedUpdateRowSelectionInCodap( | ||
| currentDayLocationRef.current._latitude, | ||
| currentDayLocationRef.current._longitude, | ||
| day |
There was a problem hiding this comment.
Since this is not part of any useCallack and/or useEffect, you can freely use state here and simply call:
debouncedUpdateRowSelectionInCodap(latitude, longitude, day)
| const getUniqueLocationsRef = useRef(getUniqueLocationsInCodapData); | ||
|
|
||
| const handleDayUpdateInTheSimTab = (day: number) => { | ||
| currentDayLocationRef.current._dayOfYear = day; |
There was a problem hiding this comment.
I think this line can be anywhere in the functional component body, e.g. right below state declarations. As any state update will trigger re-render, and this line will be executed during this re-render.
| const newDayChoice = `${_dayOfYear}` !== `${selectedDay}`; | ||
| if (rowInLocation && newDayChoice) { | ||
| setDayOfYear(selectedDay); | ||
| currentDayLocationRef.current._dayOfYear = selectedDay; |
There was a problem hiding this comment.
As above, probably you don't need this ref update here.
| }; | ||
|
|
||
| initialize(); | ||
| }, []); | ||
|
|
||
| const handleDataContextChange = useCallback(async (listenerRes: ClientNotification) => { | ||
| console.log("| dataContextChangeNotice: ", listenerRes); |
| _longitude: longitude, | ||
| _dayOfYear: dayOfYear | ||
| }; | ||
| }, [latitude, longitude, dayOfYear]); |
There was a problem hiding this comment.
I think you don't need to wrap that in useEffect. It can be anywhere in the functional component body. I usually place it right after the ref declaration.
| @@ -23,6 +23,7 @@ export const useCodapData = () => { | |||
| if (result.success) { | |||
| let dc = result.values; | |||
| let lastCollection = dc.collections[dc.collections.length - 1]; | |||
| console.trace(); | |||
PT-187887881 Selected Row Sync
PT-188109247 When Sim is accessed, it moves to the front
.caseSearch