Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Dropdown updates #36

Merged
merged 2 commits into from
Aug 27, 2024
Merged

More Dropdown updates #36

merged 2 commits into from
Aug 27, 2024

Conversation

pjanik
Copy link
Member

@pjanik pjanik commented Aug 27, 2024

https://www.pivotaltracker.com/story/show/188162567

Continuation of the previous PR: Adds up/down arrow navigation to dropdowns without text search, fixes keyboard handling, and updates the 'My Locations' implementation to use the new Dropdown component.

@pjanik pjanik requested a review from kswenson August 27, 2024 17:45
Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@pjanik pjanik merged commit 0f696a5 into main Aug 27, 2024
5 checks passed
@pjanik pjanik deleted the 188162567-custom-dropdown-2 branch August 27, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants