Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with scrollbars, tabs, and dimensions in CODAP #43

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

pjanik
Copy link
Member

@pjanik pjanik commented Aug 29, 2024

https://www.pivotaltracker.com/story/show/188185792

This PR makes the plugin looks as expected when embedded in CODAP. One issue was that tabs were incorrectly hidden, causing even small tabs to take up a lot of space, which triggered scrollbars and other issues. Also, a few other similar fixes were implemented to address related problems.

@pjanik pjanik requested a review from dougmartin August 29, 2024 18:45
Copy link
Member

@dougmartin dougmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@pjanik pjanik merged commit 130bc90 into main Aug 29, 2024
5 checks passed
@pjanik pjanik deleted the 188185792-fix-sizing-in-codap branch August 29, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants