188300239 Fix joining with a new table #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcelroy
reviewed
Sep 19, 2024
| @@ -34,7 +34,7 @@ export const JoinWithoutMerging = (props: JoinWithoutMergingProps) => { | |||
| </button> | |||
| <button | |||
| disabled={!joinShareId || (!personalDataLabel && !lastPersonalDataLabel)} | |||
| onClick={joinShare}> | |||
| onClick={() => joinShare()}> | |||
There was a problem hiding this comment.
Would it be a little better to not use the anonymous function and keep this as onClick={joinShare}?
In a previous change, it looks like you added the anonymous function so you could pass an argument. But you're no longer passing an argument here, so maybe it's not necessary?
There was a problem hiding this comment.
I was quite surprised, but the change from () => joinShare() to joinShare is what caused the bug. I now realize that when it's just joinShare, the click event gets passed to joinShare as an argument, which the function definitely wasn't prepared to handle.
emcelroy
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT Story: https://www.pivotaltracker.com/story/show/188300239
A minor stylistic change I made in another recent PR caused a bug. Lesson learned: change as little as necessary. Especially if your project has no automated tests.