Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

188115683 Remove Placeholder Item When Possible #96

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

tealefristoe
Copy link
Contributor

@tealefristoe tealefristoe commented Aug 15, 2024

PT Story: https://www.pivotaltracker.com/story/show/188115683

This PR fixes the issue of a user's placeholder item sticking around in a shared table after it is no longer useful. Whenever cases are added by a user, the top case is removed if it has no values and there is at least one additional case.

Other improvements:

  • Removes an extra create collection API request.
  • Minor code cleanup.

Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@tealefristoe tealefristoe merged commit 0935ad0 into master Aug 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants