chore: restore original isFiniteNumber implementation, lint fixes [PT…

…-187965959]
concord-consortium · Jul 18, 2024 · 45afcf5 · 45afcf5
1 parent 0ab4e00
commit 45afcf5
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 48 deletions.
diff --git a/v3/src/utilities/date-parser.test.ts b/v3/src/utilities/date-parser.test.ts
@@ -97,11 +97,10 @@ describe('isValidDateSpec', () => {
       min: 30,
       sec: 45,
       subsec: 123
-    };
-    expect(isValidDateSpec(validDateSpec)).toEqual(validDateSpec);
-  });
-
-  test('returns null when year is NaN', () => {
+    }
+    expect(isValidDateSpec(validDateSpec)).toEqual(validDateSpec)
+  })
+test('returns null when year is NaN', () => {
     const invalidDateSpec = {
       year: NaN,
       month: 7,
@@ -110,11 +109,10 @@ describe('isValidDateSpec', () => {
       min: 30,
       sec: 45,
       subsec: 123
-    };
-    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy();
-  });
-
-  test('returns null when month is out of range', () => {
+    }
+    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy()
+  })
+test('returns null when month is out of range', () => {
     const invalidDateSpec = {
       year: 2023,
       month: 13,
@@ -123,11 +121,10 @@ describe('isValidDateSpec', () => {
       min: 30,
       sec: 45,
       subsec: 123
-    };
-    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy();
-  });
-
-  test('returns null when day is out of range', () => {
+    }
+    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy()
+  })
+test('returns null when day is out of range', () => {
     const invalidDateSpec = {
       year: 2023,
       month: 7,
@@ -136,11 +133,10 @@ describe('isValidDateSpec', () => {
       min: 30,
       sec: 45,
       subsec: 123
-    };
-    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy();
-  });
-
-  test('returns null when hour is out of range', () => {
+    }
+    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy()
+  })
+test('returns null when hour is out of range', () => {
     const invalidDateSpec = {
       year: 2023,
       month: 7,
@@ -149,11 +145,10 @@ describe('isValidDateSpec', () => {
       min: 30,
       sec: 45,
       subsec: 123
-    };
-    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy();
-  });
-
-  test('returns null when minute is out of range', () => {
+    }
+    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy()
+  })
+test('returns null when minute is out of range', () => {
     const invalidDateSpec = {
       year: 2023,
       month: 7,
@@ -162,11 +157,10 @@ describe('isValidDateSpec', () => {
       min: 60,
       sec: 45,
       subsec: 123
-    };
-    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy();
-  });
-
-  test('returns null when second is out of range', () => {
+    }
+    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy()
+  })
+test('returns null when second is out of range', () => {
     const invalidDateSpec = {
       year: 2023,
       month: 7,
@@ -175,11 +169,10 @@ describe('isValidDateSpec', () => {
       min: 30,
       sec: 60,
       subsec: 123
-    };
-    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy();
-  });
-
-  test('returns null when subsecond is NaN', () => {
+    }
+    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy()
+  })
+test('returns null when subsecond is NaN', () => {
     const invalidDateSpec = {
       year: 2023,
       month: 7,
@@ -188,7 +181,7 @@ describe('isValidDateSpec', () => {
       min: 30,
       sec: 45,
       subsec: NaN
-    };
-    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy();
-  });
-});
+    }
+    expect(isValidDateSpec(invalidDateSpec)).toBeFalsy()
+  })
+})
diff --git a/v3/src/utilities/math-utils.test.ts b/v3/src/utilities/math-utils.test.ts
@@ -49,14 +49,6 @@ describe("math-utils", () => {
         expect(isFiniteNumber(-Infinity)).toBe(false)
         expect(isFiniteNumber(NaN)).toBe(false)
       })
-      it("should return true for numbers that are strings", () => {
-        expect(isFiniteNumber("1")).toBe(true)
-        expect(isFiniteNumber("1.1")).toBe(true)
-        expect(isFiniteNumber("0")).toBe(true)
-        expect(isFiniteNumber("Infinity")).toBe(false)
-        expect(isFiniteNumber("-Infinity")).toBe(false)
-        expect(isFiniteNumber("NaN")).toBe(false)
-      })
       it("should return false for non-numbers", () => {
         expect(isFiniteNumber("")).toBe(false)
         expect(isFiniteNumber("foo")).toBe(false)

diff --git a/v3/src/utilities/math-utils.ts b/v3/src/utilities/math-utils.ts
@@ -105,7 +105,7 @@ export function neededSigDigitsArrayForQuantiles(quantiles: number[], values: nu
 }
 
 export function isFiniteNumber(x: any): x is number {
-  return Number.isFinite(Number.parseFloat(x))
+  return x != null && Number.isFinite(x)
 }
 
 export function goodTickValue(iMin: number, iMax: number) {