feat: empty values for color attribute show swatch when editing

concord-consortium · May 20, 2024 · 4faeb08 · 4faeb08
1 parent 2d4102a
commit 4faeb08
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/v3/src/components/case-table/case-table.scss b/v3/src/components/case-table/case-table.scss
@@ -282,6 +282,7 @@ $table-body-font-size: 8pt;
           .cell-edit-color-swatch-interior {
             width: 100%;
             height: 100%;
+            border: 1px solid gray;
           }
         }
       }

diff --git a/v3/src/components/case-table/color-cell-text-editor.tsx b/v3/src/components/case-table/color-cell-text-editor.tsx
@@ -54,7 +54,7 @@ export default function ColorCellTextEditor({ row, column, onRowChange, onClose
   const color = supportColors && inputValue ? parseColor(inputValue, { colorNames }) : undefined
   const hexColor = color ? parseColorToHex(color, { colorNames }) : undefined
   // show the color swatch if the initial value appears to be a color (no change mid-edit)
-  const showColorSwatch = useRef(!!hexColor)
+  const showColorSwatch = useRef(!!hexColor || attribute?.userType === "color")
 
   useEffect(() => {
     selectAllCases(data, false)