Merge pull request #1285

Fix for bug found in prior PR for specifying num stdErrors
concord-consortium · May 30, 2024 · 75fed09 · 75fed09
2 parents 094edeb + 29d79f7
commit 75fed09
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/...nts/graph/adornments/univariate-measures/standard-error/standard-error-adornment-model.ts b/...nts/graph/adornments/univariate-measures/standard-error/standard-error-adornment-model.ts
@@ -19,9 +19,11 @@ export const StandardErrorAdornmentModel = UnivariateMeasureAdornmentModel
     setNumStErrs(numStErrs: number) {
       self._numStErrs = numStErrs
       self.dynamicNumStErrs = undefined
+      self.invalidateMeasures()
     },
     setDynamicNumStErrs(numStErrs: number | undefined) {
       self.dynamicNumStErrs = numStErrs
+      self.invalidateMeasures()
     }
   }))
   .views(self => ({

diff --git a/v3/src/components/graph/adornments/univariate-measures/univariate-measure-adornment-model.ts b/v3/src/components/graph/adornments/univariate-measures/univariate-measure-adornment-model.ts
@@ -19,6 +19,9 @@ export const MeasureInstance = types.model("MeasureInstance", {
   setValue(value: number) {
     self.value = value
     self.isValid = true
+  },
+  setIsValid(isValid: boolean) {
+    self.isValid = isValid
   }
 }))
 
@@ -78,6 +81,9 @@ export const UnivariateMeasureAdornmentModel = AdornmentModel
     },
     setShowMeasureLabels(showLabels: boolean) {
       self.showMeasureLabels = showLabels
+    },
+    invalidateMeasures() {
+      self.measures.forEach(measure => measure.setIsValid(false))
     }
   }))
   .views(self => ({