Adds units to legend attribute label (#1509)

concord-consortium · Sep 25, 2024 · 9653590 · 9653590
1 parent 9556707
commit 9653590
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/v3/src/components/data-display/components/legend/legend-attribute-label.tsx b/v3/src/components/data-display/components/legend/legend-attribute-label.tsx
@@ -25,6 +25,7 @@ export const LegendAttributeLabel =
       const dataset = dataConfiguration?.dataset,
         attributeID = dataConfiguration?.attributeID('legend'),
         attributeName = (attributeID ? dataset?.attrFromID(attributeID)?.name : '') ?? '',
+        attributeUnits = (attributeID ? dataset?.attrFromID(attributeID)?.units : '') ?? '',
         labelFont = vars.labelFont,
         labelBounds = getStringBounds(attributeName, labelFont),
         tX = axisGap,
@@ -40,7 +41,7 @@ export const LegendAttributeLabel =
               .attr('data-testid', className)
               .attr('x', tX)
               .attr('y', tY)
-              .text(attributeName)
+              .text(`${attributeName}${attributeUnits ? ` (${attributeUnits})` : ''}`)
         )
     }, [dataConfiguration])
 

diff --git a/v3/src/components/graph/components/graph-attribute-label.tsx b/v3/src/components/graph/components/graph-attribute-label.tsx
@@ -67,7 +67,7 @@ export const GraphAttributeLabel =
       }
       return attrIDs.map(anID => dataset?.attrFromID(anID))
                     .filter(attr => attr?.name !== '')
-                    .map(attr => `${attr?.name} ${attr?.units ? `(${attr?.units})` : ""}`.trim())
+                    .map(attr => `${attr?.name}${attr?.units ? ` (${attr?.units})` : ""}`.trim())
                     .join(', ')
     }, [dataConfiguration?.secondaryRole, dataset, getAttributeIDs, getClickHereCue,
       graphModel.pointsFusedIntoBars, place])