188104017 v3 Input Row Tab (#1403)

* Remove blur handlers.
concord-consortium · Aug 15, 2024 · e52669a · e52669a
1 parent fcd56d0
commit e52669a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 18 deletions.
diff --git a/v3/src/components/case-table/cell-text-editor.test.tsx b/v3/src/components/case-table/cell-text-editor.test.tsx
@@ -26,9 +26,7 @@ describe("CellTextEditor", () => {
     expect(editor).toHaveClass("rdg-text-editor")
     await user.keyboard("1")
     fireEvent.blur(editor)
-    // fails for some reason even though the function is clearly called
-    // expect(onRowChange).toHaveBeenCalled()
-    expect(onClose).toHaveBeenCalled()
+    expect(onRowChange).toHaveBeenCalled()
   })
 
   it("should render with dataset", async () => {
@@ -42,8 +40,6 @@ describe("CellTextEditor", () => {
     expect(editor).toHaveClass("rdg-text-editor")
     await user.keyboard("1")
     fireEvent.blur(editor)
-    // fails for some reason even though the function is clearly called
-    // expect(onRowChange).toHaveBeenCalled()
-    expect(onClose).toHaveBeenCalled()
+    expect(onRowChange).toHaveBeenCalled()
   })
 })
diff --git a/v3/src/components/case-table/cell-text-editor.tsx b/v3/src/components/case-table/cell-text-editor.tsx
@@ -43,7 +43,6 @@ export default function CellTextEditor({ row, column, onRowChange, onClose }: TR
       ref={autoFocusAndSelect}
       value={valueRef.current}
       onChange={(event) => handleChange(event.target.value)}
-      onBlur={() => onClose(true)}
     />
   )
 }
diff --git a/v3/src/components/case-table/color-cell-text-editor.tsx b/v3/src/components/case-table/color-cell-text-editor.tsx
@@ -78,11 +78,6 @@ export default function ColorCellTextEditor({ row, column, onRowChange, onClose
 
   const { isOpen: isPaletteOpen, onToggle: togglePalette } = useDisclosure()
 
-  function handleSwatchPointerDown(event: React.PointerEvent) {
-    // prevent blurring the input
-    event.preventDefault()
-  }
-
   function handleSwatchClick(event: React.MouseEvent) {
     togglePalette()
   }
@@ -91,15 +86,10 @@ export default function ColorCellTextEditor({ row, column, onRowChange, onClose
     updateValue(event.target.value)
   }
 
-  function handleInputBlur() {
-    !isPaletteOpen && acceptValue()
-  }
-
   const swatchStyle: React.CSSProperties | undefined = showColorSwatch.current ? { background: color } : undefined
   const inputElt = <InputElt
                     value={inputValue}
                     onChange={handleInputColorChange}
-                    onBlur={handleInputBlur}
                   />
 
   return swatchStyle
@@ -113,7 +103,6 @@ export default function ColorCellTextEditor({ row, column, onRowChange, onClose
           >
             <PopoverTrigger>
               <button className="cell-edit-color-swatch"
-                onPointerDown={handleSwatchPointerDown}
                 onClick={handleSwatchClick}>
                 <div className="cell-edit-color-swatch-interior" style={swatchStyle}/>
               </button>