Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Intercept Locked option missing from Measures menu (PT-187628148) #1271

Merged
merged 1 commit into from
May 21, 2024

Conversation

emcelroy
Copy link
Contributor

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (912e18a) to head (26414f4).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
- Coverage   85.82%   85.28%   -0.55%     
==========================================
  Files         478      482       +4     
  Lines       22696    22940     +244     
  Branches     6021     5734     -287     
==========================================
+ Hits        19479    19564      +85     
- Misses       2947     3211     +264     
+ Partials      270      165     -105     
Flag Coverage Δ
cypress 73.92% <ø> (-0.56%) ⬇️
jest 52.11% <ø> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emcelroy emcelroy marked this pull request as ready for review May 20, 2024 15:20
@emcelroy emcelroy requested a review from bfinzer May 20, 2024 15:21
Copy link
Contributor

@bfinzer bfinzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻LGTM
Nice simplification of complicated logic

@emcelroy emcelroy merged commit 34c45ec into main May 21, 2024
7 of 8 checks passed
@emcelroy emcelroy deleted the 187628148-fix-intercept-locked-option-missing branch May 21, 2024 00:55
@kswenson kswenson added the v3 CODAP v3 label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 CODAP v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants