-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix summary case card issues. (PT-188001359) #1526
Open
lublagg
wants to merge
5
commits into
main
Choose a base branch
from
188001359-fix-summary-bugs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+104
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1526 +/- ##
==========================================
- Coverage 85.17% 80.97% -4.21%
==========================================
Files 562 562
Lines 28074 28094 +20
Branches 7713 7729 +16
==========================================
- Hits 23911 22748 -1163
- Misses 3860 4996 +1136
- Partials 303 350 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3 Run #4523
Run Properties:
|
Project |
codap-v3
|
Branch Review |
188001359-fix-summary-bugs
|
Run status |
Failed #4523
|
Run duration | 09m 15s |
Commit |
993c6e734a: Fix lint errors.
|
Committer | lublagg |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
0
|
Pending |
29
|
Skipped |
0
|
Passing |
227
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/text.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Text tile > updates text title with undo/redo |
Test Replay
Screenshots
|
lublagg
changed the title
Fix selection issues + button text size. (PT-188001359)
Fix summary case card issues. (PT-188001359)
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following issues:
I also noticed some other bugs while working on the above that were all tied to how we were keeping track of the
summarizedCollections
and whether or not to show the summary view. Instead of having the components pass back information to the model to update thesummarizedCollections
prop on the Case Card model,summarizedCollections
is now a view on the model that updates whenever there is a change in the selected cases.