Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix summary case card issues. (PT-188001359) #1526

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lublagg
Copy link
Contributor

@lublagg lublagg commented Oct 1, 2024

Addresses the following issues:

  • Bottom button font size
  • If you drag over a selection of cases in a graph, then the data card view should go into summary mode, but just be a summary of those selected cases.
  • If you navigate at one of the parent levels, the automatically selects all of the cases present in the child cards, so, since a selection of more than one case occurs, it should go into summary mode.

I also noticed some other bugs while working on the above that were all tied to how we were keeping track of the summarizedCollections and whether or not to show the summary view. Instead of having the components pass back information to the model to update the summarizedCollections prop on the Case Card model, summarizedCollections is now a view on the model that updates whenever there is a change in the selected cases.

@lublagg lublagg requested a review from emcelroy October 1, 2024 16:33
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 94.20290% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.97%. Comparing base (cb6c017) to head (993c6e7).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
v3/src/components/case-card/case-card-model.ts 94.23% 3 Missing ⚠️
v3/src/components/case-card/card-view.tsx 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1526      +/-   ##
==========================================
- Coverage   85.17%   80.97%   -4.21%     
==========================================
  Files         562      562              
  Lines       28074    28094      +20     
  Branches     7713     7729      +16     
==========================================
- Hits        23911    22748    -1163     
- Misses       3860     4996    +1136     
- Partials      303      350      +47     
Flag Coverage Δ
cypress 68.48% <96.96%> (-5.97%) ⬇️
jest 53.31% <2.89%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Oct 1, 2024

codap-v3    Run #4523

Run Properties:  status check failed Failed #4523  •  git commit 993c6e734a: Fix lint errors.
Project codap-v3
Branch Review 188001359-fix-summary-bugs
Run status status check failed Failed #4523
Run duration 09m 15s
Commit git commit 993c6e734a: Fix lint errors.
Committer lublagg
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 29
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 227
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/text.spec.ts • 1 failed test

View Output

Test Artifacts
Text tile > updates text title with undo/redo Test Replay Screenshots

@lublagg lublagg changed the title Fix selection issues + button text size. (PT-188001359) Fix summary case card issues. (PT-188001359) Oct 1, 2024
@kswenson kswenson added the v3 CODAP v3 label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 CODAP v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants