186182704 formula column background #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables value editing when attribute has a formula
Splits case card test to 2 context so mouseSensor does not interfere with attribute menu clicks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
=======================================
Coverage 85.10% 85.10%
=======================================
Files 563 563
Lines 28149 28155 +6
Branches 7728 7731 +3
=======================================
+ Hits 23955 23961 +6
Misses 3888 3888
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 08m 46s |
| Commit |
|
| Committer | Evangeline Ireland |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
30
|
Skipped
|
0
|
Passing
|
227
|
| View all changes introduced in this branch ↗︎ | |
kswenson
approved these changes
Oct 2, 2024
lublagg
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Adds formula column background color * Adds formula background styling to case card value cell. Disables value editing when attribute has a formula * Adds Cypress test to verify background color when attribute is a formula Splits case card test to 2 context so mouseSensor does not interfere with attribute menu clicks * PR fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds background color to columns with formula.
Adds background color to value cell in case card if attribute has a formula
Disables cell editing in case card when attribute has a formula.
Adds cypress test to verify background color for cells with formula values.
Splits case-card cypress test so that two different URLs are used to load CODAP. The
mouseSensorquery param was interfering with test that required the attribute menu.