187323603 drag over webview bug #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswenson
approved these changes
Oct 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
==========================================
- Coverage 85.10% 85.09% -0.01%
==========================================
Files 563 563
Lines 28149 28156 +7
Branches 7728 7730 +2
==========================================
+ Hits 23955 23959 +4
- Misses 3888 4041 +153
+ Partials 306 156 -150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 08m 53s |
| Commit |
|
| Committer | Evangeline Ireland |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
30
|
Skipped
|
0
|
Passing
|
227
|
| View all changes introduced in this branch ↗︎ | |
lublagg
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Adds a pointer capture on component drag * remove commented out code * PR fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where dragging components over a webview makes the component lose the pointer focus. This captures the pointer while dragging a component