Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several things going on here:
GraphDataConfigurationModel
's attempt to synchronize itsfilteredCases
array after itsDataSet
was destroyed.Once that was fixed, there were still several clients that were attempting to access the defunct
DataSet
triggering warnings. These have also been fixed:FilteredCases
class now responds to disposal of itsDataSet
, thus preventing further access.CaseTile
'sHideShowMenuList
checks whether itsDataSet
is alive before accessing it. (We conventionally avoidisAlive
in models, but in components there often isn't a better way.)CountAdornmentComponent
was properly usingmstAutorun
, but the model it was attached to was theCountAdornmentModel
, not the axis models that were also accessed within theautorun
.mstAutorun
andmstReaction
have been extended to support an array of model dependencies or a single model and so now theCountAdornmentComponent
can specify all of its model dependencies. (I have wondered for some time whether we would ever encounter a situation in which a single model dependency was insufficient for these utilities and now we have.)