188497528 case tile filter formula editor

[eireland]

Changes case table/card edit filter formula modal to use the regular formula editor modal.

Refactored Cypress formula-helper.ts to avoid circular reference between table and the helper.

[cypress]

codap-v3    Run #5210

Run Properties:   Passed #5210  •  dc370b988e: 188497528 case tile filter formula editor (#1617)

Project	codap-v3
Branch Review	main
Run status	Passed #5210
Run duration	01m 52s
Commit	dc370b988e: 188497528 case tile filter formula editor (#1617)
Committer	Evangeline Ireland
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	3
View all changes introduced in this branch ↗︎

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.54%. Comparing base (e9fbc5b) to head (a795d36).
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1617      +/-   ##
==========================================
- Coverage   85.68%   85.54%   -0.14%     
==========================================
  Files         600      600              
  Lines       30332    30337       +5     
  Branches     7749     7760      +11     
==========================================
- Hits        25989    25951      -38     
+ Misses       4188     4004     -184     
- Partials      155      382     +227     

Flag	Coverage Δ
cypress	74.88% <100.00%> (-0.25%)	⬇️
jest	52.65% <33.33%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kswenson]

👍 Looks good -- nice cleanup

[kswenson]

Suggested change

	// addNewAttribute(collectionIndex = 1) {
	// table.addNewAttribute(collectionIndex)
	// },
	// renameAttribute(currentAttributeName: string, newAttributeName: string, collectionIndex = 1) {
	// table.renameAttribute(currentAttributeName, newAttributeName, collectionIndex)
	// },
	// deleteAttribute(attributeName: string, collectionIndex = 1) {
	// table.deleteAttribute(attributeName, collectionIndex)
	// },
	// addFormula(attributeName: string, formula: string, collectionIndex = 1) {
	// table.addFormula(attributeName, formula, collectionIndex)
	// },
	// verifyValues(attributeName: string, values: Array<any>, collectionIndex = 1) {
	// table.verifyFormulaValues(attributeName, values, collectionIndex)
	// },
	// checkFormulaExists(attributeName: string, formula: string, collectionIndex = 1) {
	// table.checkFormulaExists(attributeName, formula, collectionIndex)
	// },
	// editFormula(attributeName: string, formula: string, collectionIndex = 1) {
	// table.editFormula(attributeName, formula, collectionIndex)
	// },
	// createNewDataset() {
	// table.createNewTableFromToolShelf()
	// },
	// insertCases(rowIndex: number, numOfCases: number) {
	// table.openIndexMenuForRow(rowIndex)
	// table.insertCases(numOfCases, "after")
	// },
	// changeSliderVariableName(sliderVariableName: string) {
	// slider.changeVariableName(sliderVariableName)
	// },
	// changeSliderValue(sliderValue: string) {
	// slider.changeVariableValue(sliderValue)
	// },
	// addSlider() {
	// c.getIconFromToolShelf("slider").click()
	// },
	// deleteSlider() {
	// c.closeComponent("slider")
	// },