Right justifies numeric types and changes font to a monspaced font #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1621 +/- ##
==========================================
+ Coverage 85.02% 85.67% +0.64%
==========================================
Files 600 601 +1
Lines 30307 30429 +122
Branches 7740 7778 +38
==========================================
+ Hits 25768 26069 +301
+ Misses 4384 4205 -179
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kswenson
approved these changes
Nov 15, 2024
Comment on lines
52
to
53
| cellClass: row => clsx("codap-data-cell", `rowId-${row.__id__}`, {"formula-column": hasFormula, | ||
| "right-justify": userType === "numeric" || type === "numeric"}), |
There was a problem hiding this comment.
Number formatting should be applied to values, not columns. I'll add a commit.
Comment on lines
328
to
329
| // font-family: 'Roboto Mono', monospace; | ||
| font-family: 'Inconsolata', monospace; |
There was a problem hiding this comment.
I told myself I wasn't going to do this, but I couldn't resist looking into other fonts. Take a look at it after my commit and see what you think.
There was a problem hiding this comment.
Looks good. The 1 bugs me a little, but the 4 matches better 🤷♀️
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 06m 49s |
| Commit |
|
| Committer | Evangeline Ireland |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
35
|
Skipped
|
0
|
Passing
|
220
|
| View all changes introduced in this branch ↗︎ | |
…ium/codap into 182991523-number-styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precision is implemented with this PR #1620