Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try using setup-chrome #1627

Merged
merged 3 commits into from
Nov 15, 2024
Merged

try using setup-chrome #1627

merged 3 commits into from
Nov 15, 2024

Conversation

scytacki
Copy link
Member

@scytacki scytacki commented Nov 15, 2024

This is faster than using the cypress built docker container. It only adds 8s instead of 25s to the build.

this might be faster than using the cypress built docker container
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.16%. Comparing base (1b91df9) to head (1c41a8d).
Report is 5 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (1b91df9) and HEAD (1c41a8d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1b91df9) HEAD (1c41a8d)
jest 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1627      +/-   ##
==========================================
- Coverage   83.27%   75.16%   -8.12%     
==========================================
  Files         600      564      -36     
  Lines       30401    24741    -5660     
  Branches     7775     7569     -206     
==========================================
- Hits        25317    18597    -6720     
- Misses       4929     6141    +1212     
+ Partials      155        3     -152     
Flag Coverage Δ
cypress 75.16% <ø> (+3.22%) ⬆️
jest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Nov 15, 2024

codap-v3    Run #5227

Run Properties:  status check passed Passed #5227  •  git commit 18e8e64206: Increment the build number
Project codap-v3
Branch Review main
Run status status check passed Passed #5227
Run duration 02m 03s
Commit git commit 18e8e64206: Increment the build number
Committer eireland
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

as far as I can tell we are not paying for the the build minutes
@scytacki
Copy link
Member Author

The code coverage is down is because the only changes here are to the github actions files. This prevents the main build from running.

@scytacki scytacki marked this pull request as ready for review November 15, 2024 22:12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Now I know where the number of workers lives.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using @v1 ensures we get updates within the same major version of Chrome while avoiding breaking changes.

@nstclair-cc
Copy link
Collaborator

LGTM. The flaky 16+1 color palette test will be addressed by @eireland, yes? @eireland let me know if I can help with fixing that particular test.

@scytacki scytacki merged commit 28b3727 into main Nov 15, 2024
13 of 15 checks passed
@scytacki scytacki deleted the 188575672-setup-chrome-action branch November 15, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants