-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try using setup-chrome #1627
try using setup-chrome #1627
Conversation
this might be faster than using the cypress built docker container
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1627 +/- ##
==========================================
- Coverage 83.27% 75.16% -8.12%
==========================================
Files 600 564 -36
Lines 30401 24741 -5660
Branches 7775 7569 -206
==========================================
- Hits 25317 18597 -6720
- Misses 4929 6141 +1212
+ Partials 155 3 -152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3 Run #5227
Run Properties:
|
Project |
codap-v3
|
Branch Review |
main
|
Run status |
Passed #5227
|
Run duration | 02m 03s |
Commit |
18e8e64206: Increment the build number
|
Committer | eireland |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
3
|
View all changes introduced in this branch ↗︎ |
as far as I can tell we are not paying for the the build minutes
The code coverage is down is because the only changes here are to the github actions files. This prevents the main build from running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Now I know where the number of workers lives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using @v1 ensures we get updates within the same major version of Chrome while avoiding breaking changes.
This is faster than using the cypress built docker container. It only adds 8s instead of 25s to the build.