Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show date precision options if user has chosen another type #1629

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

kswenson
Copy link
Member

@kswenson kswenson commented Nov 16, 2024

  • fix logic for when to show date options vs. numeric options in Edit Attribute Properties dialog
  • disable the precision options if neither are appropriate

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.57%. Comparing base (6f3b40e) to head (64d393c).
Report is 19 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1629       +/-   ##
===========================================
+ Coverage   67.88%   85.57%   +17.69%     
===========================================
  Files         600      600               
  Lines       30405    30407        +2     
  Branches     8351     8352        +1     
===========================================
+ Hits        20639    26022     +5383     
+ Misses       9611     4064     -5547     
- Partials      155      321      +166     
Flag Coverage Δ
cypress 75.05% <100.00%> (+31.06%) ⬆️
jest 52.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

cypress bot commented Nov 16, 2024

codap-v3    Run #5291

Run Properties:  status check passed Passed #5291  •  git commit 6832342f01: fix: don't show date precision options if user has chosen another type (#1629)
Project codap-v3
Branch Review main
Run status status check passed Passed #5291
Run duration 06m 00s
Commit git commit 6832342f01: fix: don't show date precision options if user has chosen another type (#1629)
Committer Kirk Swenson
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 35
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 220
View all changes introduced in this branch ↗︎

@kswenson kswenson marked this pull request as ready for review November 16, 2024 07:34
Copy link
Contributor

@eireland eireland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@kswenson kswenson merged commit 6832342 into main Nov 19, 2024
24 checks passed
@kswenson kswenson deleted the 187967988-fix-date-precision branch November 19, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants