Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

188392104 case card formula #1638

Merged
merged 9 commits into from
Nov 19, 2024
Merged

188392104 case card formula #1638

merged 9 commits into from
Nov 19, 2024

Conversation

eireland
Copy link
Contributor

@eireland eireland commented Nov 19, 2024

Makes number types follow attribute precision in case cards.
Disables the Editable attribute property if the attribute has a formula.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.67%. Comparing base (bc4ee5d) to head (4d7fcc4).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
v3/src/components/case-card/case-attr-view.tsx 90.90% 1 Missing ⚠️
v3/src/components/case-table/use-rows.ts 0.00% 1 Missing ⚠️
...onents/case-tile-common/attribute-format-utils.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
+ Coverage   85.54%   85.67%   +0.13%     
==========================================
  Files         600      601       +1     
  Lines       30432    30520      +88     
  Branches     7787     8338     +551     
==========================================
+ Hits        26032    26148     +116     
- Misses       4016     4051      +35     
+ Partials      384      321      -63     
Flag Coverage Δ
cypress 75.21% <88.00%> (+0.20%) ⬆️
jest 52.68% <25.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

cypress bot commented Nov 19, 2024

codap-v3    Run #5301

Run Properties:  status check passed Passed #5301  •  git commit 3e9dd4ffe8: 188392104 case card formula (#1638)
Project codap-v3
Branch Review main
Run status status check passed Passed #5301
Run duration 05m 55s
Commit git commit 3e9dd4ffe8: 188392104 case card formula (#1638)
Committer Evangeline Ireland
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 35
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 220
View all changes introduced in this branch ↗︎

@eireland eireland marked this pull request as ready for review November 19, 2024 16:13
Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM -- I added a commit with a couple of small tweaks.

@eireland eireland merged commit 3e9dd4f into main Nov 19, 2024
21 checks passed
@eireland eireland deleted the 188392104-case-card-formula branch November 19, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants