-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
188392104 case card formula #1638
Conversation
…ch case card to use the same renderAttributeValue code as the table.
Formula value cells obey precision
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1638 +/- ##
==========================================
+ Coverage 85.54% 85.67% +0.13%
==========================================
Files 600 601 +1
Lines 30432 30520 +88
Branches 7787 8338 +551
==========================================
+ Hits 26032 26148 +116
- Misses 4016 4051 +35
+ Partials 384 321 -63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
codap-v3 Run #5301
Run Properties:
|
Project |
codap-v3
|
Branch Review |
main
|
Run status |
Passed #5301
|
Run duration | 05m 55s |
Commit |
3e9dd4ffe8: 188392104 case card formula (#1638)
|
Committer | Evangeline Ireland |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
35
|
Skipped |
0
|
Passing |
220
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM -- I added a commit with a couple of small tweaks.
Makes number types follow attribute precision in case cards.
Disables the
Editable
attribute property if the attribute has a formula.