Wait 24 hours before deleting a root.

concord-consortium · Sep 11, 2024 · 3fb3b35 · 3fb3b35
1 parent 2fd2247
commit 3fb3b35
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/functions-v2/src/at-midnight.ts b/functions-v2/src/at-midnight.ts
@@ -15,7 +15,7 @@ export const atMidnight = onSchedule("0 0 * * *", runAtMidnight);
 export async function runAtMidnight() {
   await cleanFirebaseRoots({
     appMode: "qa",
-    hoursAgo: 6,
+    hoursAgo: 24,
     logger,
     dryRun: false,
   });

diff --git a/functions-v2/test/at-midnight.test.ts b/functions-v2/test/at-midnight.test.ts
@@ -73,12 +73,12 @@ describe("atMidnight", () => {
       .toHaveBeenCalledWith("Found 1 roots to delete");
   });
 
-  test("only clean up firestore roots older than 6 hours", async () => {
+  test("only clean up firestore roots older than 24 hours", async () => {
     await writeFirestoreRoot(Date.now() - HOUR);
-    await writeFirestoreRoot(Date.now() - 2*HOUR);
-    await writeFirestoreRoot(Date.now() - 5*HOUR);
-    await writeFirestoreRoot(Date.now() - 8*HOUR);
-    await writeFirestoreRoot(Date.now() - 24*HOUR);
+    await writeFirestoreRoot(Date.now() - 12*HOUR);
+    await writeFirestoreRoot(Date.now() - 23*HOUR);
+    await writeFirestoreRoot(Date.now() - 25*HOUR);
+    await writeFirestoreRoot(Date.now() - 48*HOUR);
 
     await runAtMidnight();