scaling the angle for the real servo

src/models/stores/serial.ts

@@ -172,9 +172,11 @@ export class SerialDevice {
 
   public writeToOutForServo(n:number, liveOutputType: string){
     const outputConfig = NodeLiveOutputTypes.find(o => o.name === liveOutputType);
-    if (this.hasPort() && outputConfig?.angleBase !== undefined){
-      const constrainedAngle = Math.min(180, Math.max(0, n));
-      this.writer.write(`${constrainedAngle.toString()}\n`);
+    if (this.hasPort() && outputConfig?.angleOffset !== undefined){
+      const scaledAngle = (outputConfig.angleScale * n) + outputConfig.angleOffset;
+      const roundedScaled = Math.round(scaledAngle);
+       //console.log("| GOT:", n, "| SENDING :", roundedScaled);
+      this.writer.write(`${roundedScaled.toString()}\n`);
     }
   }
 }

src/plugins/dataflow/model/utilities/node.ts

@@ -427,6 +427,8 @@ export const NodeLiveOutputTypes = [
     name: "Servo",
     icon: ServoIcon,
     angleBase: 0,
+    angleOffset: 30,
+    angleScale: 2 / 3,
     sweep: 180
   }
 ];

src/plugins/dataflow/nodes/factories/live-output-rete-node-factory.tsx

@@ -61,13 +61,12 @@ export class LiveOutputReteNodeFactory extends DataflowReteNodeFactory {
         }
 
         if(kServoOutputTypes.includes(outputType)){
-          // TODO: test with real servo and invalid value, does it go to 0 or 180, or not move at all?
-          // if goes from zero to 180, then we can just constrain, like this:
+          // angles out of range are set to the nearest valid value
           newValue = Math.min(Math.max(newValue, 0), 180);
           nodeValue?.setDisplayMessage(`${newValue}°`);
 
-          // otherwise, we need to check if the value is valid,
-          // and if not, we need to set it to the last valid value
+          // leaving the alternative approach in place if needed
+          // this just will not move if given an invalid value
           // const isValidServoValue = newValue >= 0 && newValue <= 180;
           // if (!isValidServoValue) newValue = getLastValidServoValue(_node);
         }