-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
186506915 sort by bookmarks starred #2148
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2148 +/- ##
==========================================
- Coverage 84.13% 84.05% -0.09%
==========================================
Files 680 680
Lines 33531 33546 +15
Branches 8740 8743 +3
==========================================
- Hits 28212 28196 -16
- Misses 5038 5067 +29
- Partials 281 283 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Passing run #10558 ↗︎
Details:
Review all test suite changes for PR #2148 ↗︎ |
Changed four-up in Dashboard > Published Work to include bookmark instead of star
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. There are 3 cypress tests that are failing because the class name of the sub tab was changed from "starred" to "bookmarked".
The 1st cypress test is failing because of a change to the moth unit, and that is unrelated to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Fulfills the following tickets
[MultiDoc] Sort by Bookmarks (Starred)
Link to
clue-curriculum
PRconcord-consortium/clue-curriculum#142
Branch name:
186506915-sort-bookmarks-clue-repo
Deployed branch
https://collaborative-learning.concord.org/branch/sort-by-bookmarks-starred/?appMode=demo&demoName=dennis1&fakeClass=1&fakeUser=teacher:1&problem=1.1&unit=example-config-subtabs&curriculumBranch=sort-bookmarks-clue-repo
_
LocalHost
http://localhost:8080/?appMode=dev&demoName=dennis1&fakeClass=1&fakeUser=teacher:1&problem=1.1&unit=example-config-subtabs&curriculumBranch=sort-bookmarks-clue-repo
After PR merges - we can get rid of the
curriculumBranch