Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

186506915 sort by bookmarks starred #2148

Merged
merged 19 commits into from
Jan 25, 2024

Conversation

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (056c70b) 84.13% compared to head (e1ed075) 84.05%.

Files Patch % Lines
src/models/stores/sorted-documents.ts 0.00% 8 Missing and 1 partial ⚠️
src/components/document/sort-work-view.tsx 0.00% 4 Missing ⚠️
src/components/navigation/document-view.tsx 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2148      +/-   ##
==========================================
- Coverage   84.13%   84.05%   -0.09%     
==========================================
  Files         680      680              
  Lines       33531    33546      +15     
  Branches     8740     8743       +3     
==========================================
- Hits        28212    28196      -16     
- Misses       5038     5067      +29     
- Partials      281      283       +2     
Flag Coverage Δ
cypress-regression 74.84% <30.43%> (-0.10%) ⬇️
cypress-smoke 36.86% <30.43%> (-0.02%) ⬇️
jest 51.82% <26.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jan 16, 2024

Passing run #10558 ↗︎

0 86 4 0 Flakiness 0

Details:

Fixed canvas_test_spec.js and teacher_curatio_spec.js
Project: collaborative-learning Commit: e1ed075ed6
Status: Passed Duration: 11:48 💡
Started: Jan 24, 2024 11:51 PM Ended: Jan 25, 2024 12:03 AM

Review all test suite changes for PR #2148 ↗︎

@dennisrcao dennisrcao changed the base branch from master to 186665118-sort-by-strategy January 18, 2024 23:01
@dennisrcao dennisrcao marked this pull request as ready for review January 22, 2024 18:47
Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. There are 3 cypress tests that are failing because the class name of the sub tab was changed from "starred" to "bookmarked".

The 1st cypress test is failing because of a change to the moth unit, and that is unrelated to this PR.

Base automatically changed from 186665118-sort-by-strategy to master January 24, 2024 15:22
@scytacki scytacki self-requested a review January 25, 2024 01:11
Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tejal-shah tejal-shah requested a review from a team January 25, 2024 17:07
@tejal-shah tejal-shah merged commit 027a3da into master Jan 25, 2024
14 of 16 checks passed
@tejal-shah tejal-shah deleted the 186506915-sort-by-bookmarks-starred branch January 25, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants