Add points by hand toolbar button #2213
Conversation
1 flaky test on run #11659 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Draw Tool Tile > Text |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #2213 ↗︎
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2213 +/- ##
==========================================
+ Coverage 83.42% 83.45% +0.02%
==========================================
Files 688 689 +1
Lines 34075 34138 +63
Branches 8836 8848 +12
==========================================
+ Hits 28428 28490 +62
- Misses 5352 5353 +1
Partials 295 295
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -598,7 +642,7 @@ export const GraphModel = TileContentModel | |||
| (ids) => { | |||
| ids.forEach(id => { | |||
| if (!self._idColors.has(id)) { | |||
| self.setColorForIdWithoutUndo(id, self.nextColor); | |||
| self.setColorForId(id, self.nextColor); | |||
There was a problem hiding this comment.
This may require a more subtle fix, but I was getting warnings about withoutUndo being called as a child action.
There was a problem hiding this comment.
Yeah there is a option you pass to withoutUndo so it basically doesn't print this warning.
There was a problem hiding this comment.
OK, I changed it back to setColorForIdWithoutUndo and added the unlessChildAction option there.
|
Looks good to me. I tried it out with this link: |
bgoldowsky
added
the
pending QA review
scytacki
added
approved QA review
and removed
pending QA review
|
I see based on the PT story that the functionality was approved. I'm going to merge this. |
Adds the ability for the Graph tile to have its own dataset.
As specified in PT-186610168, adds a toolbar button that creates a dataset attached to the graph, and a layer for it. Two attributes are created and set up to be plotted. Subsequent work will allow points to be added. The name of the new dataset can be edited.