186143109 drawing toolbar in new toolbar system #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update app config - add unused onTouchHold to TileToolbarButtonProps - registration - create modal buttons - stub out action-on-drawing buttons - comment out stayles that will need to come back in, stub new styles file - remove some functionality from drawing-tile, to be added back - set up new drawing-toolbar-buttons file, leave old one in for reference
Passing run #12685 ↗︎
Details:
Review all test suite changes for PR #2309 ↗︎ |
|||||||||||||||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2309 +/- ##
==========================================
- Coverage 84.51% 84.43% -0.09%
==========================================
Files 705 711 +6
Lines 36007 36033 +26
Branches 9190 9195 +5
==========================================
- Hits 30432 30423 -9
- Misses 5256 5290 +34
- Partials 319 320 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- to be refactored, but saving for reference - in case we need to break out again - group, ungroup, duplicate, delete
…09-drawing-toolbar-update
…ettes are responsive
- uses Boris' general button from PR #2296 - updates general toolbar to support above - keeps current image upload mechanism by adding state var to context
- vectorType needs to be passed to svg as vectortype - strokeDashArray needs to be strokeDasharray
bgoldowsky
requested changes
May 28, 2024
|
|
||
| const tipOptions = useTooltipOptions(); | ||
| const { onTouchStart, onTouchEnd, onMouseDown, onMouseUp, onClick: handleOnClick } = useTouchHold( | ||
| () => onTouchHold?.({} as React.MouseEvent), |
There was a problem hiding this comment.
Seems like either onTouchHold should be changed to not expect an argument, or an actual event argument should be passed.
- if multiple objects are selected and any are a group, enable ungroup button - shared data buttons should be registered from shared data - fix imports - cleanup
- in cases where user might expect long click to work because there is a dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT-186143109
This reimplements that drawing tile toolbar using the general toolbar system
ToolbarButtonSvg- a component that is just the svg portion of a button that will accept svgsettingsand can be placed within the generalTileToolbarButton