Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLUE version number #2375

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

johnTcrawford
Copy link
Contributor

Update version number from "4.3.0" to "5.15.0", because I just can't stand it being that out of date any longer.

…use I just couldn't stand it being that out of date any longer.
…0", because I just couldn't stand it being that out of date any longer."

This reverts commit 3c2471e.
…se I just can't stand it being that out of date any longer.
Copy link

cypress bot commented Aug 14, 2024



Test summary

108 0 3 0Flakiness 0


Run details

Project collaborative-learning
Status Passed
Commit d9d56f8
Started Aug 14, 2024 8:23 PM
Ended Aug 14, 2024 8:33 PM
Duration 09:28 💡
OS Linux Debian -
Browser Chrome 121

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.73%. Comparing base (b0818c7) to head (d9d56f8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2375      +/-   ##
==========================================
- Coverage   85.74%   85.73%   -0.01%     
==========================================
  Files         722      722              
  Lines       37223    37223              
  Branches     9478     9478              
==========================================
- Hits        31915    31913       -2     
- Misses       5003     5005       +2     
  Partials      305      305              
Flag Coverage Δ
cypress 77.08% <ø> (?)
cypress-regression ?
cypress-smoke 28.22% <ø> (ø)
jest 48.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nstclair-cc nstclair-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🎉

We'll also want to update the documentation to the latest build to reflect this change. That's the bottom of the first page here.

Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer that we just remove it. Otherwise we're going to have do an extra commit every time we do a release to update it. With it removed the version in the UI will show up as "unknown".

It should get added automatically to releases when we follow the usual release steps that we do here:
https://github.com/concord-consortium/docs/blob/main/docs/%F0%9F%9A%80%20Release%20%26%20Deploy%20Processes/CLUE.md

With a little more work we can turn that "unknown" into the the name of the branch that is deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants