Revert "Automation for Creating Polygons from Existing Points" #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collaborative-learning
|
||||||||||||||||||||||||||||
| Project |
collaborative-learning
|
| Branch Review |
revert-2360-187809206-automation-polygon-points
|
| Run status |
|
| Run duration | 01m 45s |
| Commit |
|
| Committer | Natalya St. Clair |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
1
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2400 +/- ##
===========================================
- Coverage 85.98% 54.64% -31.34%
===========================================
Files 738 729 -9
Lines 37855 37704 -151
Branches 9635 9612 -23
===========================================
- Hits 32550 20605 -11945
- Misses 5002 16072 +11070
- Partials 303 1027 +724
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bgoldowsky
approved these changes
Sep 11, 2024
nstclair-cc
deleted the
revert-2360-187809206-automation-polygon-points
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2360
Oh no! It looks like when the code was merged into master, the length of one of the polygons defaulted to 4.9 instead of 5.0. I’ve always been concerned about something like this happening in CLUE and am wondering if it’s possible to test on the Cloud before merging. In the meantime I'll ask John for help on how to resolve these kinds of issues.