Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187809206 add tolerance statements #2402

Merged
merged 7 commits into from
Sep 16, 2024

Conversation

nstclair-cc
Copy link
Collaborator

@nstclair-cc nstclair-cc commented Sep 11, 2024

Pull Request: Fix for Automation Issue

PT #187809206

Summary:

This PR addresses the automation issue by adding tolerance statements to improve the accuracy of the test. The issue was resolved by implementing a .to.be.closeTo comparison.

Changes:

  • Added .to.be.closeTo comparison for verifying point positions.
  • Introduced tolerance to handle slight variations in the test data.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.01%. Comparing base (2b88ec1) to head (f02af94).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2402      +/-   ##
==========================================
+ Coverage   85.91%   86.01%   +0.10%     
==========================================
  Files         736      736              
  Lines       37816    37816              
  Branches     9623     9623              
==========================================
+ Hits        32489    32528      +39     
+ Misses       5022     4986      -36     
+ Partials      305      302       -3     
Flag Coverage Δ
cypress ?
cypress-regression 77.59% <ø> (+0.23%) ⬆️
cypress-smoke 28.06% <ø> (ø)
jest 48.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Sep 11, 2024

collaborative-learning    Run #13754

Run Properties:  status check passed Passed #13754  •  git commit f02af9484e: Merge branch 'master' into 187809206-add-tolerance-statements
Project collaborative-learning
Branch Review 187809206-add-tolerance-statements
Run status status check passed Passed #13754
Run duration 01m 42s
Commit git commit f02af9484e: Merge branch 'master' into 187809206-add-tolerance-statements
Committer Natalya St. Clair
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

Copy link
Contributor

@bgoldowsky bgoldowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 👍

@nstclair-cc nstclair-cc merged commit 7b1f57b into master Sep 16, 2024
16 of 17 checks passed
@nstclair-cc nstclair-cc deleted the 187809206-add-tolerance-statements branch September 16, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants