Bar graph sync #2404
Merged
Bar graph sync #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ID update function to fix tile copy issue.
Prevent changes in read-only mode. When changing primary attribute, reset secondary as part of the same action to support undo. Make EditableAxisLabel handle things more locally to fix sync bugs. Test read-only views Test undo and redo of each operation. Add classes in DocEditorApp to support testing.
collaborative-learning
|
||||||||||||||||||||||||||||
| Project |
collaborative-learning
|
| Branch Review |
188129121-bar-graph-sync
|
| Run status |
|
| Run duration | 14m 51s |
| Commit |
|
| Committer | Boris Goldowsky |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
6
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 188127118-bar-graph-link #2404 +/- ##
============================================================
+ Coverage 85.93% 85.98% +0.05%
============================================================
Files 741 741
Lines 37981 37996 +15
Branches 9688 9689 +1
============================================================
+ Hits 32640 32672 +32
+ Misses 5035 5019 -16
+ Partials 306 305 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Base automatically changed from
185294648-bar-graph-legend
to
188127118-bar-graph-link
September 16, 2024 14:44
scytacki
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT-188129121
This PR fixes some issues noted in the original bar graph work.
A lot more tests have been added, including checking that the display in the read-only views is correct after each change (this requiring some updates to the standalone editor HTML and
TableToolTile.jsso that each view could ba accurately targeted by Cypress).Also logging has been added.