live update sorted documents #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove unnecessary DocumentContext around SimpleDocumentItem - switch usage of IDocumentMetadata to IDocumentMetadataModel (the MST model) - add disposer for the metadata docs watcher - make SimpleDocumentItem an observing component so it updates when the visibility changes. - update tests to work with the new metadataDocsFiltered property - update sorted-documents to have two MST models for the filtered and withoutUnit metadata docs. These models are kept in sync with the Firestore query results. - update the queries to use Firebase `onSnapshot` listeners instead of just calling `get` - have the `onSnapshot` listeners merge the exemplar docs and then apply the new query results to the MST models - turn firestoreMetadataDocs into a view that combines all of the documents together.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2408 +/- ##
=======================================
Coverage 86.16% 86.17%
=======================================
Files 736 736
Lines 37814 37842 +28
Branches 9626 9624 -2
=======================================
+ Hits 32584 32609 +25
- Misses 4931 4935 +4
+ Partials 299 298 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
collaborative-learning
|
||||||||||||||||||||||||||||
| Project |
collaborative-learning
|
| Branch Review |
188123062-live-update-sorted-docs
|
| Run status |
|
| Run duration | 13m 45s |
| Commit |
|
| Committer | Scott Cytacki |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
emcelroy
approved these changes
Sep 19, 2024
Comment on lines
357
to
358
| problem: metadataDoc?.problem || undefined, | ||
| investigation: metadataDoc?.investigation || undefined, |
There was a problem hiding this comment.
This confused me a little and I want to be sure I understand. Did you add || undefined here because metadataDoc.problem and metadataDoc.investigation are typed as maybeNull and we should use undefined here instead if they are null?
There was a problem hiding this comment.
Another good catch. I've updated this with a comment and unified the way they are handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onSnapshotlisteners instead of just callinggetonSnapshotlisteners merge the exemplar docs and then apply the new query results to the MST models